Please create an account to participate in the Slashdot moderation system

 



Forgot your password?
typodupeerror
×
Programming

Are You Too Good For Code Reviews? 495

theodp writes "Why do some programmers,' asks Chris Hemedinger, 'place little value on code reviews?' This apparently includes even Programming Greats like Ken 'C' Thompson, who quipped, 'we were all pretty good coders' when asked about the importance of code reviews in his work. Hemedinger, on the other hand, subscribes to the school of thought that peer code reviews are Things Everyone Should Do. Not only do reviews keep you on your toes, Hemedinger says, they also 'improve quality, ensure continuity, and keep it fresh. Who can argue against that?'"
This discussion has been archived. No new comments can be posted.

Are You Too Good For Code Reviews?

Comments Filter:
  • Pure Arrogance (Score:2, Informative)

    by Anonymous Coward on Friday July 08, 2011 @10:53AM (#36694704)

    Anyone who is anti-code review is an arrogant snot. No one is perfect, and we all have the capacity to overlook things.

  • Re:this (Score:5, Informative)

    by Omnifarious ( 11933 ) * <eric-slash@omnRA ... minus herbivore> on Friday July 08, 2011 @12:12PM (#36695940) Homepage Journal

    I've caught bugs in code review that would never in a million years have been caught by testing. The customer would've encountered them sporadically, and in situations in which they'd come to rely on the broken behavior working implicitly. The would've submitted a bug report and we would've been unable to replicate the problem in house. The customer's opinion of us would be lowered, and we'd have all these bug reports in our system that nobody could figure out.

    That is, until someone reviewed the code and discovered the bug.

    So, basically what you're doing is robbing Peter to pay Paul. By not doing the reviews you end up with less time in the long run, not more.

"The only way I can lose this election is if I'm caught in bed with a dead girl or a live boy." -- Louisiana governor Edwin Edwards

Working...